Enclose moose - #563
Conversation
…s for both levels and submissions
…ed routing structure; minor improvements to tests
…er submit); added player_submission to InitialRead and score_distribution to UnlockedRead; updated router to match; changed admin_get_all_submissions to admin_get_all_level_submissions; updated and slightly improved tests
…nullable, only shown if player_submission is not None
|
How is optimal_is_unique meant to be used by the app? If the allotted number of walls is more than the one used for the optimal solution, the extra walls can be placed by the solver anywhere outside the enclosed area and lead to optimal_is_unique=false even if there's only one way to place the walls which actually enclose the space. Your test grid has only one enclosed area solution, but three wall-solutions: No clue if that messes with the way you wanna build the game in the app. |
|
optimal_is_unique is currently not used by anything. I just added it because it was interesting to see when creating the level. Since optimal_solution only keeps track of one solution, I prefer the solution to be unique (as does enclose.horse). |
…ions so deleted users don't orphan, release date uses factory for default to get actual .now time, block leading or trailing newlines in grid
georgelgeback
left a comment
georgelgeback
left a comment
There was a problem hiding this comment.
Overall really good and I am excited for the new game! I pushed some unambiguous changes directly, but check my comments too.
|
That should be everything! |
…dget. Add regression tests
georgelgeback
left a comment
georgelgeback
left a comment
There was a problem hiding this comment.
I added some tests and found an error when trying to update wall_budget to None (which we want to have no effect I think), and fixed it by filtering out None values from the updates dict. Check it out and if you're OK with it, the PR LGTM
|
Alright, thanks for the thorough review! |
2 participants
Added support for enclose.moose. Installed one new package (ortools). Let me know if anything looks weird, don't really know what i'm doing!